entrouvert
/
publik-base-theme
15
1
Fork 1
Code Issues Pull Requests 12 Releases Wiki Activity

scss: make .loader class available in all pages (#89221) #561

Merged
fpeters merged 1 commits from wip/89221-loader into main 2024-04-12 07:15:29 +02:00
Conversation 0 Commits 1 Files Changed 2 +38 -35
fpeters commented 2024-04-06 08:21:16 +02:00
Owner
Copy Link
No description provided.
fpeters added 1 commit 2024-04-06 08:21:16 +02:00
gitea/publik-base-theme/pipeline/head This commit looks good Details
05635f3415 scss: make .loader class available in all pages (#89221)
fpeters force-pushed wip/89221-loader from 05635f3415 to b1c6de8f88 2024-04-06 08:27:40 +02:00 Compare
fpeters force-pushed wip/89221-loader from b1c6de8f88 to 2825774faa 2024-04-06 08:32:27 +02:00 Compare
fpeters reviewed 2024-04-06 08:34:07 +02:00
static/includes/_layout.scss Outdated
@ -37,0 +37,4 @@
html {
@if variable-exists(primary-color) {
--primary-color: #{$primary-color};
}
fpeters commented 2024-04-06 08:32:40 +02:00
Author
Owner
Copy Link

Il peut rester des intégrations graphiques sans primary-color (ex: static/bouches-du-rhone/style.scss) pour lesquelles il ne faut planter, mais par rapport au code existant je retire ici le fallback qui définissait --primary-color: #ccc, autant ne pas introduire de fausse idée sur l'existance de cette variable.

Il peut rester des intégrations graphiques sans primary-color (ex: static/bouches-du-rhone/style.scss) pour lesquelles il ne faut planter, mais par rapport au code existant je retire ici le fallback qui définissait --primary-color: #ccc, autant ne pas introduire de fausse idée sur l'existance de cette variable.
fpeters reviewed 2024-04-06 08:34:41 +02:00
static/includes/_misc.scss
@ -849,1 +849,4 @@
}
.loader {
--loader-color: var(--primary-color, black);
fpeters commented 2024-04-06 08:34:41 +02:00
Author
Owner
Copy Link

Et plutôt le fallback ainsi, au niveau de l'élément qui en a besoin.

Et plutôt le fallback ainsi, au niveau de l'élément qui en a besoin.
lguerin approved these changes 2024-04-08 15:30:30 +02:00
fpeters merged commit 9912b1795e into main 2024-04-12 07:15:29 +02:00
fpeters deleted branch wip/89221-loader 2024-04-12 07:15:29 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
lguerin
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/publik-base-theme#561
No description provided.
Delete Branch "wip/89221-loader"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?