entrouvert
/
passerelle
15
0
Fork 0
Code Issues Pull Requests 15 Releases Activity

esup_signature: do not send empty parameters (#79611) #320

Open
ecazenave wants to merge 1 commits from wip/79611-esup-empty-params into main
pull from: wip/79611-esup-empty-params
merge into: entrouvert:main
Conversation 0 Commits 1 Files Changed 2 +71 -13
ecazenave commented 2023-07-11 15:41:20 +02:00
Owner
Copy Link
No description provided.
ecazenave added 1 commit 2023-07-11 15:41:20 +02:00
gitea/passerelle/pipeline/head This commit looks good Details
78c27ffe27 esup_signature: do not send empty parameters (#79611)
ecazenave changed title from WIP: esup_signature: do not send empty parameters (#79611) to esup_signature: do not send empty parameters (#79611) 2023-07-11 17:31:08 +02:00
tnoel approved these changes 2023-07-13 14:33:46 +02:00
tnoel left a comment
Owner
Copy Link

J'ai fait un commentaire pour montrer que j'ai relu. Je valide cette version, tu modifies si tu veux le code.

J'ai fait un commentaire pour montrer que j'ai relu. Je valide cette version, tu modifies si tu veux le code.
passerelle/apps/esup_signature/models.py
@ -284,3 +297,2 @@
'targetUrl': post_data.get('target_url', ''),
}
params = add_list_params(params, (('recipients_cc_emails', 'recipientsCCEmails'),), post_data)
tnoel commented 2023-07-13 14:33:07 +02:00
Owner
Copy Link

Sur les appels à add_params ou add_list_params j'aurais juste écrit :

add_list_params(params, (('recipients_cc_emails', 'recipientsCCEmails'),), post_data)

sans le params = devant qui ne sert en fait à rien, et donc retiré les return params des fonctions add_params et add_list_params. Mais c'est juste moi.

Sur les appels à `add_params` ou `add_list_params` j'aurais juste écrit : `add_list_params(params, (('recipients_cc_emails', 'recipientsCCEmails'),), post_data)` sans le `params =` devant qui ne sert en fait à rien, et donc retiré les `return params` des fonctions `add_params` et `add_list_params`. Mais c'est juste moi.
All checks were successful
gitea/passerelle/pipeline/head This commit looks good
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
Reviewers
No reviewers
tnoel
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/passerelle#320
No description provided.
Delete Branch "wip/79611-esup-empty-params"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?