entrouvert
/
passerelle
15
0
Fork 0
Code Issues Pull Requests 14 Releases Activity

esabora: return error content in response (#71368) #3

Merged
aberriot merged 1 commits from wip/71368-esabora-report-errors into main 2022-11-17 11:19:24 +01:00
Conversation 2 Commits 1 Files Changed 2 +51 -7
aberriot commented 2022-11-17 10:15:33 +01:00
Owner
Copy Link
No description provided.
aberriot added 1 commit 2022-11-17 10:15:34 +01:00
gitea-wip/passerelle/pipeline/pr-main This commit looks good Details
gitea-wip/passerelle/pipeline/pr-wip/71638-franceconnec-data-add-dgfip-api-url-field This commit looks good Details
56b6baea78 esabora: return error content in response (#71368)
smihai approved these changes 2022-11-17 11:18:58 +01:00
aberriot merged commit 56b6baea78 into main 2022-11-17 11:19:24 +01:00
aberriot deleted branch wip/71368-esabora-report-errors 2022-11-17 11:19:24 +01:00
Ghost commented 2022-11-17 14:08:42 +01:00
First-time contributor
Copy Link

En cas de non-JSON j'aurai ajouté le « payload brut » (response.content) tel quel dans l'APIError, mais c'est pas grave, on l'aura dans Passerelle, ça suffira large.

En cas de non-JSON j'aurai ajouté le « payload brut » (response.content) tel quel dans l'APIError, mais c'est pas grave, on l'aura dans Passerelle, ça suffira large.
Ghost commented 2022-11-17 14:10:16 +01:00
First-time contributor
Copy Link

Il manque aussi un test sur le cas « Invalid JSON response » mais c'est ma faute j'avais qu'à relire plus vite que Serghei :)

Il manque aussi un test sur le cas « Invalid JSON response » mais c'est ma faute j'avais qu'à relire plus vite que Serghei :)
Sign in to join this conversation.
Reviewers
No reviewers
smihai
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/passerelle#3
No description provided.
Delete Branch "wip/71368-esabora-report-errors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?