entrouvert
/
chrono
14
1
Fork 0
Code Issues Pull Requests 7 Releases Wiki Activity

tests: fix event order in api fillslot tests (#89598) #248

Merged
yweber merged 1 commits from wip/89598-fix-random-api-test-failure into main 2024-04-15 16:39:47 +02:00
Conversation 0 Commits 1 Files Changed 1 +2 -2
yweber commented 2024-04-15 16:02:08 +02:00
Owner
Copy Link
No description provided.
yweber added 1 commit 2024-04-15 16:02:08 +02:00
yweber force-pushed wip/89598-fix-random-api-test-failure from db74d36fbf to c3da7e8014 2024-04-15 16:02:37 +02:00 Compare
yweber force-pushed wip/89598-fix-random-api-test-failure from c3da7e8014 to a128944948 2024-04-15 16:14:08 +02:00 Compare
vdeniaud reviewed 2024-04-15 16:17:27 +02:00
tests/api/fillslot/test_events.py Outdated
@ -743,0 +731,4 @@
expt = {
('event', Booking.objects.filter(event=agenda._event).latest('pk').pk),
('event-2', Booking.objects.filter(event=agenda._event_2).latest('pk').pk),
}
vdeniaud commented 2024-04-15 16:17:27 +02:00
Owner
Copy Link

Idée comme ça, les évènements étant triés par date de début, le fix pourrait être simplement de faire démarrer le deuxième évènement après le premier, genre 'start_datetime': now() + datetime.timedelta(days=1, hours=1)

Idée comme ça, les évènements étant triés par date de début, le fix pourrait être simplement de faire démarrer le deuxième évènement après le premier, genre `'start_datetime': now() + datetime.timedelta(days=1, hours=1)`
yweber commented 2024-04-15 16:20:28 +02:00
Author
Owner
Copy Link

Merci, bonne idée, je vais plutôt faire ça :)

Merci, bonne idée, je vais plutôt faire ça :)
yweber marked this conversation as resolved
yweber force-pushed wip/89598-fix-random-api-test-failure from a128944948 to 0563e0642d 2024-04-15 16:25:40 +02:00 Compare
yweber changed title from WIP: tests: replace ordered comparison by sets comparison (#89598) to tests: replace ordered comparison by sets comparison (#89598) 2024-04-15 16:29:04 +02:00
yweber changed title from tests: replace ordered comparison by sets comparison (#89598) to tests: fix event order in api fillslot tests (#89598) 2024-04-15 16:29:42 +02:00
vdeniaud approved these changes 2024-04-15 16:37:54 +02:00
yweber merged commit 0563e0642d into main 2024-04-15 16:39:47 +02:00
yweber deleted branch wip/89598-fix-random-api-test-failure 2024-04-15 16:39:48 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
vdeniaud
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/chrono#248
No description provided.
Delete Branch "wip/89598-fix-random-api-test-failure"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?