From 8da6be4e73d811ad641d94d99be128ef5a6a906e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Laur=C3=A9line=20Gu=C3=A9rin?= <zebuline@entrouvert.com>
Date: Fri, 27 Jan 2023 11:13:42 +0100
Subject: [PATCH] backoffice: fix form inspect with missing external wf on
 trace (#73823)

---
 tests/backoffice_pages/test_form_inspect.py | 8 ++++++++
 wcs/workflow_traces.py                      | 4 +---
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/tests/backoffice_pages/test_form_inspect.py b/tests/backoffice_pages/test_form_inspect.py
index 0b70ddc24..2dd22da6e 100644
--- a/tests/backoffice_pages/test_form_inspect.py
+++ b/tests/backoffice_pages/test_form_inspect.py
@@ -733,6 +733,14 @@ def test_inspect_page_actions_traces(pub):
     workflow.store()
     app.get(formdata.get_url(backoffice=True) + 'inspect')
 
+    # delete external workflow
+    workflow.remove_self()
+    resp = app.get(target_formdata.get_url(backoffice=True) + 'inspect')
+    assert '>Actions Tracing</' in resp
+    assert [x.text for x in resp.pyquery('#inspect-timeline .event a')] == ['Created (by workflow action)']
+    event_links = [x.attrib['href'] for x in resp.pyquery('#inspect-timeline .event a')]
+    assert event_links[0] == '#missing-_create'
+
 
 def test_inspect_page_missing_carddef_error(pub):
     create_user(pub, is_admin=True)
diff --git a/wcs/workflow_traces.py b/wcs/workflow_traces.py
index 877abc0c9..6a55e6423 100644
--- a/wcs/workflow_traces.py
+++ b/wcs/workflow_traces.py
@@ -77,9 +77,7 @@ class WorkflowTrace(sql.WorkflowTrace):
             if self.event_args.get('external_workflow_id'):
                 from wcs.workflows import Workflow
 
-                self._external_workflow = Workflow.get(
-                    self.event_args.get('external_workflow_id'), ignore_errors=True
-                )
+                self._external_workflow = Workflow.get(self.event_args.get('external_workflow_id'))
         return self._external_workflow
 
     def get_external_url(self, global_event):
-- 
2.39.2