entrouvert/wcs
entrouvert
/
wcs
14
1
Fork 0
Code Issues Pull Requests 44 Releases Activity

backoffice: fix form inspect with missing external wf on trace (#73823) #72

Merged
lguerin merged 1 commits from wip/73823-workflowtrace-unkown-external-workflow into main 2023-01-31 16:06:30 +01:00
Conversation 0 Commits 1 Files Changed 2 +9 -3
lguerin commented 2023-01-27 11:14:47 +01:00
Owner
Copy Link
No description provided.
lguerin added 1 commit 2023-01-27 11:14:48 +01:00
lguerin reviewed 2023-01-27 11:16:00 +01:00
wcs/workflow_traces.py
@ -80,3 +80,1 @@
self._external_workflow = Workflow.get(
self.event_args.get('external_workflow_id'), ignore_errors=True
)
self._external_workflow = Workflow.get(self.event_args.get('external_workflow_id'))
lguerin commented 2023-01-27 11:16:00 +01:00
Author
Owner
Copy Link

il y a un try/except KeyError dans la méthode get_external_url qui permet de gérer ce cas

il y a un try/except KeyError dans la méthode get_external_url qui permet de gérer ce cas
fpeters approved these changes 2023-01-30 17:32:43 +01:00
lguerin merged commit 71fd2038a6 into main 2023-01-31 16:06:30 +01:00
lguerin deleted branch wip/73823-workflowtrace-unkown-external-workflow 2023-01-31 16:06:30 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
fpeters
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/wcs#72
No description provided.
Delete Branch "wip/73823-workflowtrace-unkown-external-workflow"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?