entrouvert
/
combo
16
1
Fork 0
Code Issues Pull Requests 9 Releases Wiki Activity

data: mark json config cell as invalid if not found in settings (#71168) #5

Merged
lguerin merged 1 commits from wip/71168-report-unkown-ConfigJsonCell into main 2022-12-12 18:08:33 +01:00
Conversation 0 Commits 1 Files Changed 5 +82 -4
lguerin commented 2022-11-21 12:09:53 +01:00
Owner
Copy Link
No description provided.
lguerin added 1 commit 2022-11-21 12:09:53 +01:00
lguerin reviewed 2022-11-21 12:11:45 +01:00
combo/data/models.py
@ -2360,10 +2364,15 @@ class ConfigJsonCellManager(models.Manager):
@register_cell_class
class ConfigJsonCell(JsonCellBase):
objects = ConfigJsonCellManager()
lguerin commented 2022-11-21 12:11:45 +01:00
Author
Owner
Copy Link

Ce manager fait un queryset.filter(key__in=settings.JSON_CELL_TYPES.keys())
=> nécessité d'avoir un autre manager qui ne filtre pas sur les settings, pour le job cron, et pour la page de rapport des anomalies.

Ce manager fait un `queryset.filter(key__in=settings.JSON_CELL_TYPES.keys())` => nécessité d'avoir un autre manager qui ne filtre pas sur les settings, pour le job cron, et pour la page de rapport des anomalies.
fpeters approved these changes 2022-12-12 18:05:41 +01:00
lguerin merged commit f94fedb8f5 into main 2022-12-12 18:08:33 +01:00
lguerin deleted branch wip/71168-report-unkown-ConfigJsonCell 2022-12-12 18:08:33 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
fpeters
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/combo#5
No description provided.
Delete Branch "wip/71168-report-unkown-ConfigJsonCell"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?